Skip to content

Conversation

@dvadas
Copy link
Member

@dvadas dvadas commented Aug 25, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az fleet gate ...

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings August 25, 2025 03:55
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 25, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️fleet
rule cmd_name rule_message suggest_message
⚠️ 1003 - CmdPropAdd fleet gate approve cmd fleet gate approve added property is_preview
⚠️ 1003 - CmdPropAdd fleet gate list cmd fleet gate list added property is_preview
⚠️ 1003 - CmdPropAdd fleet gate show cmd fleet gate show added property is_preview
⚠️ 1003 - CmdPropAdd fleet gate update cmd fleet gate update added property is_preview

@azure-client-tools-bot-prd
Copy link

Hi @dvadas,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR marks the Azure Fleet Gate commands as preview in the Azure CLI extension. The change adds the is_preview=True parameter to the command group definition to indicate that these commands are in preview status.

  • Adds preview flag to the fleet gate command group

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 25, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Aug 25, 2025

Hi @dvadas

Release Suggestions

Module: fleet

  • Update VERSION to 1.7.0 in src/fleet/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 25, 2025
@yonzhan yonzhan requested a review from kairu-ms August 25, 2025 04:24
@serbrech
Copy link
Member

@kairu-ms we don't want this change to trigger a release. it's ok to bundle it with other changes that are coming.
how do we deal with the version requirement in that case?

# TODO: Confirm this is the right version number you want and it matches your
# HISTORY.rst entry.
VERSION = '1.6.2'
VERSION = '1.6.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only bump up this version number will trigger a release. So please remove this line change

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 29, 2025
@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 1, 2025

Please fix CI issues

@dvadas
Copy link
Member Author

dvadas commented Sep 1, 2025

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 9081 in repo Azure/azure-cli-extensions

@kairu-ms
Copy link
Contributor

kairu-ms commented Sep 1, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

kairu-ms commented Sep 1, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit 2fe0582 into Azure:main Sep 1, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants